tree 38e8742a3e700b9057eabb964747c73d16a9410f
parent 32a1b6a70b3ec9066dd70ccf538f735a5c58e031
author Michael Buch <michaelbuch12@gmail.com> 1747730666 +0100
committer GitHub <noreply@github.com> 1747730666 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoLEDqCRC1aQ7uu5UhlAAAyLUQADwjgf5bTZGfNxt2mEFKJ8zV
 dliOslgCg0o+Az9WD+TihdV1XsWzpwtfCPVAc0fKd+fYfkwmo2mHJjbEgg7YWYSw
 QWq8vjAq9zxqMh2NGKZbk82UPLRuWm+v+Y8TkWGX8ABUGl06P40j5IDmVGq2vqW+
 ml1iTbrxkm/vQUN9PNl7OISWiePRrlcyknLK3brlZhqaxsH0kxBSgr/ru4IvZh9E
 w1OjBq19faN84M2UirrDpKtGEvQNS4Bbsw20OAyrhe7XKog2fFkSM+YJyAynKSO8
 LTPCo6rhcM/ysZRgFtNBEZrGpPRT8ARlj2xQ/+Dzszd5mDDs9w6pLxbZLyAzXyKl
 q1SOMiE9ZYA8O0205O2cnV3QgEyst+M4eymc4S+I5IPBqerMXstf8NCK+dpC+oTm
 3Y/3oXK5WbBlNbFjInS0u0v4LdnFlYqMLhRlOrkg1kbs3OLny6Dr3taO1QUblicw
 9/D60zHsA8ytvM91w69SjLkTQefuY+9cOCOfPsnEdekrpyjiRiD0znNgiReehN91
 ZLnexDe3OyXlOXfgEq7cs0qk6Hf7X/WsJ+6a5/bXjT50XyIdtgkeRPGi4sHzlhpM
 xIiBls7kodTsQcgI6k29y3Z8hmyAE6E4fjlGa/NAKUTWPMDknJTswjkKVlesKAkR
 MOJOx17UbhfhQTo9a42r
 =3iaQ
 -----END PGP SIGNATURE-----
 

[lldb][DataFormatters] Adjust retrieval of unordered_map element type (#140256)

A user ran into an issue where the libc++ `std::unordered_map` formatter
fails because it can't deduce the `element_type`. That happens because
the `node_type` is a forwad declaration. And, in fact, dsymutil stripped
the definition for `std::__1::__hash_node<...>` for a particular
instantiation. While I'm still unclear whether this is a dsymutil bug,
this patch works around said issue by getting the element type from the
`__table_` member.

Drive-by:
- Set the `m_element_type` in `Update`, which is where the other members
are initialized

I don't have a reduced example of this unfortunately. But the crux of
the issue is that `std::__1::__hash_node<...>` only has a forward
declaration in the dsym. Then trying to call `GetTypeTemplateArgument`
on that `CompilerType` fails. And even if the definition was present in
the dsym it seems like we're stopped in a context where the CU only had
a forward declaration DIE for that type and the `node_type` never ends
up being completed with the definition that lives in another CU.

rdar://150813798