| commit | d5eb0a9484013197bd04ca40ead93fd5532a0c45 | [log] [tgz] |
|---|---|---|
| author | Dimitry Andric <dimitry@andric.com> | Wed Apr 23 23:18:17 2025 +0200 |
| committer | Dimitry Andric <dimitry@andric.com> | Wed Apr 23 23:18:17 2025 +0200 |
| tree | 2b67c4bd200504643ef44b49ca0acb87771ea378 | |
| parent | 0fdb908e39b22a3c630bb6b727d71748df96f8ac [diff] |
[JITLink][i386] Avoid 'i386' name clashing with built-in macro
When compiling llvm on an actual i386 platform, both clang and gcc
define a built-in macro `i386` to the value 1. This clashes with the
`llvm::jitlink::i386` namespace:
```
In file included from llvm/lib/ExecutionEngine/JITLink/ELF_i386.cpp:18:
llvm/include/llvm/ExecutionEngine/JITLink/i386.h:19:24: error: expected '{'
19 | namespace llvm::jitlink::i386 {
| ^
llvm/include/llvm/ExecutionEngine/JITLink/i386.h:19:26: error: expected unqualified-id
19 | namespace llvm::jitlink::i386 {
| ^
```
The macro name 'i386' is obviously a historical bad choice, but since it
existed long before llvm, llvm should either rename its namespace, or
actively undefine the macro in `i386.h` (similar to e.g.
https://github.com/google/swiftshader/blob/master/third_party/llvm-16.0/Android.bp#L1510).
This particular pull request implements the rename, but is meant to
gauge opinions on how to solve this issue.
Welcome to the LLVM project!
This repository contains the source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and run-time environments.
The LLVM project has multiple components. The core of the project is itself called “LLVM”. This contains all of the tools, libraries, and header files needed to process intermediate representations and convert them into object files. Tools include an assembler, disassembler, bitcode analyzer, and bitcode optimizer.
C-like languages use the Clang frontend. This component compiles C, C++, Objective-C, and Objective-C++ code into LLVM bitcode -- and from there into object files, using LLVM.
Other components include: the libc++ C++ standard library, the LLD linker, and more.
Consult the Getting Started with LLVM page for information on building and running LLVM.
For information on how to contribute to the LLVM project, please take a look at the Contributing to LLVM guide.
Join the LLVM Discourse forums, Discord chat, LLVM Office Hours or Regular sync-ups.
The LLVM project has adopted a code of conduct for participants to all modes of communication within the project.