BU: Fix datastructure bug when copying into AFC from temporary list.

splice() may still be usable and perhaps faster,
but this is clear and certainly works.

llvm-svn: 238379
diff --git a/poolalloc/lib/DSA/BottomUpClosure.cpp b/poolalloc/lib/DSA/BottomUpClosure.cpp
index 65cb300..02e561c 100644
--- a/poolalloc/lib/DSA/BottomUpClosure.cpp
+++ b/poolalloc/lib/DSA/BottomUpClosure.cpp
@@ -660,8 +660,7 @@
       if (CS.isIndirectCall())
         ++NumIndUnresolved;
       // Remember that we could not resolve this yet!
-      DSGraph::FunctionListTy::iterator S = I++;
-      AuxCallsList.splice(AuxCallsList.end(), TempFCs, S);
+      AuxCallsList.push_back(CS);
       continue;
     }
     // If we get to this point, we know the callees, and can inline.