tree b379a3329840f4f1ac226b69249c164021b11653
parent 39418da4ab2444768ed7e94e42bcb6afc074a7b8
author Reid Kleckner <rnk@google.com> 1542152679 +0000
committer Reid Kleckner <rnk@google.com> 1542152679 +0000

[PDB] Simplify symbol handling code, NFC

- Make mergeSymbolRecords a method of PDBLinker to reduce the number of
parameters it needs.

- Remove a stale FIXME comment about error handling. We already drop
unknown symbol records, log them, and continue.

- Update a comment about why we're copying the symbol record. We do it
to realign the record. We can already mutate the symbol record memory,
it's memory allocated by relocateDebugChunk.

- Avoid the extra `CVSymbol NewSym` variable. We can mutate Sym in
place, which is best, since we're mutating the underlying record anyway.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@346817 91177308-0d34-0410-b5e6-96231b3b80d8