tree 37edd32b38f512fb188e090c937bb98301b14144
parent 5edeb580cecfe017e278678e29ed44dd584e7515
author George Rimar <grimar@accesssoftek.com> 1538559180 +0000
committer George Rimar <grimar@accesssoftek.com> 1538559180 +0000

[ELF] - Do not forget to include to .dymsym symbols that were converted to Defined.

This is the fix for
"Bug 39104 - LLD links incorrect ELF executable if version script contains "local: *;"
(https://bugs.llvm.org/show_bug.cgi?id=39104).

The issue happens when we have non-PIC program call to function in a shared library.
(for example, the PR above has R_X86_64_PC32 relocation against __libc_start_main)

LLD converts symbol to Defined in that case with the use of replaceWithDefined()

The issue is that after above we create a broken relocation because do not
include the symbol into .dynsym.

That happens when the version script is used because we treat the symbol as
STB_LOCAL if the following condition match:
VersionId == VER_NDX_LOCAL && isDefined() and do not include it to
.dynsym because of that. Patch fixes the issue.

Differential revision: https://reviews.llvm.org/D52724

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@343668 91177308-0d34-0410-b5e6-96231b3b80d8