| commit | 05f406dc7fc47255c95dad4ec7a11a0293bec24e | [log] [tgz] |
|---|---|---|
| author | George Rimar <grimar@accesssoftek.com> | Wed Oct 03 09:33:00 2018 +0000 |
| committer | George Rimar <grimar@accesssoftek.com> | Wed Oct 03 09:33:00 2018 +0000 |
| tree | 37edd32b38f512fb188e090c937bb98301b14144 | |
| parent | 5edeb580cecfe017e278678e29ed44dd584e7515 [diff] |
[ELF] - Do not forget to include to .dymsym symbols that were converted to Defined. This is the fix for "Bug 39104 - LLD links incorrect ELF executable if version script contains "local: *;" (https://bugs.llvm.org/show_bug.cgi?id=39104). The issue happens when we have non-PIC program call to function in a shared library. (for example, the PR above has R_X86_64_PC32 relocation against __libc_start_main) LLD converts symbol to Defined in that case with the use of replaceWithDefined() The issue is that after above we create a broken relocation because do not include the symbol into .dynsym. That happens when the version script is used because we treat the symbol as STB_LOCAL if the following condition match: VersionId == VER_NDX_LOCAL && isDefined() and do not include it to .dynsym because of that. Patch fixes the issue. Differential revision: https://reviews.llvm.org/D52724 git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@343668 91177308-0d34-0410-b5e6-96231b3b80d8
This directory and its subdirectories contain source code for the LLVM Linker, a modular cross platform linker which is built as part of the LLVM compiler infrastructure project.
lld is open source software. You may freely distribute it under the terms of the license agreement found in LICENSE.txt.
In order to make sure various developers can evaluate patches over the same tests, we create a collection of self contained programs.
It is hosted at https://s3-us-west-2.amazonaws.com/linker-tests/lld-speed-test.tar.xz
The current sha256 is 10eec685463d5a8bbf08d77f4ca96282161d396c65bd97dc99dbde644a31610f.