commit 1f820d84ece2ba7287bc033f8b7ec10ce05710b7
author Eric Fiselier <eric@efcs.ca> Tue Mar 05 02:10:31 2019 +0000
committer Eric Fiselier <eric@efcs.ca> Tue Mar 05 02:10:31 2019 +0000
tree 90b878b4f44f6fcfb22d819f2853dbd283bdaaf1
parent e718b5a8a82c16c313cf7fb6ce814c1d47750d27

Fix -fsanitize=vptr badness in <__debug>

Summary:

This patch fixes a lifetime bug when inserting a new container into the debug database. It is
diagnosed by UBSAN when debug mode is enabled. This patch corrects how nodes are constructed
during insertion.

The fix requires unconditionally breaking the debug mode ABI. Users should not expect ABI
stability from debug mode.

Reviewers: ldionne, serge-sans-paille, EricWF

Reviewed By: EricWF

Subscribers: mclow.lists, christof, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D58011

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@355367 91177308-0d34-0410-b5e6-96231b3b80d8