commit 0894fec50135a5eea00429fb6722a2b384d29297
author Mitch Phillips <31459023+hctim@users.noreply.github.com> Thu Jul 08 13:06:34 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Jul 15 20:05:17 2021 -0700
tree 44d5e668f96836ab16ce97ede7016d82e058015f
parent c5ac5d72557a6361acfd6b250fa5eb2248511ae1

[GWP-ASan] Change unreachable -> trap to work around DCE bug.

trapOnAddress is designed to SEGV on a specific address. Unfortunately,
with an IR change, __builtin_unreachable() ends up doing DCE on things
that have side effects, like the load that causes the trap.

Change to __builtin_trap() to avoid the optimisation.

Root cause is still an LLVM bug, and tracked in
https://bugs.llvm.org/show_bug.cgi?id=47480.

Reviewed By: eugenis

Differential Revision: https://reviews.llvm.org/D105654

GitOrigin-RevId: d458f379324967c3c408be06e21aad9bc92c54cb