commit 6aecacbb8d3d7322d588b528a34a0425444dfafd
author David Blaikie <dblaikie@gmail.com> Fri May 03 00:44:50 2019 +0000
committer David Blaikie <dblaikie@gmail.com> Fri May 03 00:44:50 2019 +0000
tree f04375d141a02ecfec4c8b535096efa564ebed00
parent b4f79aa4368802682268e2f39a29dd8f9b107b59

SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

Because diagnostics and their notes are not connected at the API level,
if the error message for an overload is emitted, then the overload
candidates are completed - if a diagnostic is emitted during that work,
the notes related to overload candidates would be attached to the latter
diagnostic, not the original error. Sort of worse, if the latter
diagnostic was disabled, the notes are disabled.

Reviewers: rsmith

Differential Revision: https://reviews.llvm.org/D61357

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@359854 91177308-0d34-0410-b5e6-96231b3b80d8