tree a3ee60f3dfb40ee137e502d33b2e941881213c7f
parent 4c3d1fab392153906386736f236ef30894e46454
author Stephane Moore <mog@google.com> 1555540146 +0000
committer Stephane Moore <mog@google.com> 1555540146 +0000

[clang-tidy] Add a check for [super self] in initializers 🔍

Summary:
This check aims to address a relatively common benign error where
Objective-C subclass initializers call -self on their superclass instead
of invoking a superclass initializer, typically -init. The error is
typically benign because libobjc recognizes that improper initializer
chaining is common¹.

One theory for the frequency of this error might be that -init and -self
have the same return type which could potentially cause inappropriate
autocompletion to -self instead of -init. The equal selector lengths and
triviality of common initializer code probably contribute to errors like
this slipping through code review undetected.

This check aims to flag errors of this form in the interests of
correctness and reduce incidence of initialization failing to chain to
-[NSObject init].

[1] "In practice, it will be hard to rely on this function.
     Many classes do not properly chain -init calls."
From  _objc_rootInit in https://opensource.apple.com/source/objc4/objc4-750.1/runtime/NSObject.mm.auto.html.

Test Notes:
Verified via `make check-clang-tools`.

Subscribers: mgorny, xazax.hun, jdoerfert, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D59806

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@358620 91177308-0d34-0410-b5e6-96231b3b80d8