tree aaefac9e37b17013855f571a2c974f2b79775064
parent d789c6ffa610ce0ad34e817d8bb557ead5fe4016
author Jonas Toth <jonas.toth@gmail.com> 1521646455 +0000
committer Jonas Toth <jonas.toth@gmail.com> 1521646455 +0000

[clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

The original check did break the green buildbot in the sanitizer build.
It took a while to redroduce and understand the issue.

There occured a stackoverflow while parsing the AST. The testcase with
256 case labels was the problem because each case label added another
stackframe. It seemed that the issue occured only in 'RelWithDebInfo' builds
and not in normal sanitizer builds.

To simplify the matchers the recognition for the different kinds of switch
statements has been moved into a seperate function and will not be done with
ASTMatchers. This is an attempt to reduce recursion and stacksize as well.

The new check removed this big testcase. Covering all possible values is still
implemented for bitfields and works there. The same logic on integer types
will lead to the issue.

Running it over LLVM gives the following results:


Differential: https://reviews.llvm.org/D40737


git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@328107 91177308-0d34-0410-b5e6-96231b3b80d8