tree 3ca73d1c544edeed8a671a97892dc3b0bf3edbe6
parent 82d421fe0a574ce2449c8d41b689bbb725f1b746
author Dmitri Gribenko <gribozavr@gmail.com> 1569581352 +0000
committer Dmitri Gribenko <gribozavr@gmail.com> 1569581352 +0000

[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Summary:
Creates a new darwin ClangTidy module and adds the darwin-dispatch-once-nonstatic check that warns about dispatch_once_t variables not in static or global storage. This catches a missing static for local variables in e.g. singleton initialization behavior, and also warns on storing dispatch_once_t values in Objective-C instance variables. C/C++ struct/class instances may potentially live in static/global storage, and are ignored for this check.

The osx.API static analysis checker can find the non-static storage use of dispatch_once_t; I thought it useful to also catch this issue in clang-tidy when possible.

This is a re-land of https://reviews.llvm.org/D67567

Reviewers: thakis, gribozavr, stephanemoore

Subscribers: Eugene.Zelenko, mgorny, xazax.hun, jkorous, arphaman, kadircet, usaxena95

Tags: #clang-tools-extra, #clang, #llvm

Differential Revision: https://reviews.llvm.org/D68109

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@373065 91177308-0d34-0410-b5e6-96231b3b80d8