tree c3af6bdd6fe070bb88a084421149489846f55711
parent bdb3a2168510d1e0d554e82a1cdeaa611358e2a7
author Simon Marchi <simon.marchi@ericsson.com> 1521643006 +0000
committer Simon Marchi <simon.marchi@ericsson.com> 1521643006 +0000

Make positionToOffset return llvm::Expected<size_t>

Summary:

To implement incremental document syncing, we want to verify that the
ranges provided by the front-end are valid.  Currently, positionToOffset
deals with invalid Positions by returning 0 or Code.size(), which are
two valid offsets.  Instead, return an llvm:Expected<size_t> with an
error if the position is invalid.

According to the LSP, if the character value exceeds the number of
characters of the given line, it should default back to the end of the
line.  It makes sense in some contexts to have this behavior, and does
not in other contexts.  The AllowColumnsBeyondLineLength parameter
allows to decide what to do in that case, default back to the end of the
line, or return an error.

Reviewers: ilya-biryukov

Subscribers: klimek, ilya-biryukov, jkorous-apple, ioeric, cfe-commits

Differential Revision: https://reviews.llvm.org/D44673

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@328100 91177308-0d34-0410-b5e6-96231b3b80d8