tree 87ecb7726ce77e765f37b4429d6d6f37f9049544
parent 86c9adace8956c069897198248a150cf4a9b0b02
author Shuai Wang <shuaiwang@google.com> 1537219688 +0000
committer Shuai Wang <shuaiwang@google.com> 1537219688 +0000

[clang-tidy] Fix tests for performance-for-range-copy

Test failed as D52120 made ExprMutationAnalyzer smarter, fixed by:
- Add move-ctor for `Mutable` to make it actually movable.
- Properly implement `remove_reference`.

The failed test case is:
void negativeVarIsMoved() {
  for (auto M : View<Iterator<Mutable>>()) {
    auto Moved = std::move(M);
  }
}
Before D52120, `std::move(M)` itself is considered as a mutation to `M`,
while after D52120 it's only considered as a cast to rvalue, the
move-assignment is what causes the actual mutation. The test case didn't
mock things properly so the intended move-assignement was actually a
copy-assignment.

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@342417 91177308-0d34-0410-b5e6-96231b3b80d8