tree 5be4aa768d8563fcd7351ffe5356cb0ca48b42dc
parent 613396c9c7f468276585229f4edff07bbab5cd5e
author Stephane Moore <mog@google.com> 1569539099 +0000
committer Stephane Moore <mog@google.com> 1569539099 +0000

[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

Summary:
Creates a new darwin ClangTidy module and adds the darwin-dispatch-once-nonstatic check that warns about dispatch_once_t variables not in static or global storage. This catches a missing static for local variables in e.g. singleton initialization behavior, and also warns on storing dispatch_once_t values in Objective-C instance variables. C/C++ struct/class instances may potentially live in static/global storage, and are ignored for this check.

The osx.API static analysis checker can find the non-static storage use of dispatch_once_t; I thought it useful to also catch this issue in clang-tidy when possible.

Contributed By: mwyman

Reviewers: benhamilton, hokein, stephanemoore, aaron.ballman, gribozavr

Reviewed By: stephanemoore, gribozavr

Subscribers: jkorous, arphaman, kadircet, usaxena95, NoQ, xazax.hun, lebedev.ri, mgorny, cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D67567

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@373028 91177308-0d34-0410-b5e6-96231b3b80d8