tree 4d2fcf15c3207d31b74d6afd7df9fd7e920273fc
parent 2da50e1b5df99f1512362118e96b85a4276083ad
author Eric Liu <ioeric@google.com> 1529069658 +0000
committer Eric Liu <ioeric@google.com> 1529069658 +0000

[clangd] UI for completion items that would trigger include insertion.

Summary:
For completion items that would trigger include insertions (i.e. index symbols
that are not #included yet), add a visual indicator "+" before the completion
label. The inserted headers will appear in the completion detail.

Open to suggestions for better visual indicators; "+" was picked because it
seems cleaner than a few other candidates I've tried (*, #, @ ...).

The displayed header would be like a/b/c.h (without quote) or <vector> for system
headers. I didn't add quotation or "#include" because they can take up limited
space and do not provide additional information after users know what the
headers are. I think a header alone should be obvious for users to infer that
this is an include header..

To align indentation, also prepend ' ' to labels of candidates that would not
trigger include insertions (only for completions where index results are
possible).

Vim:
{F6357587}

vscode:
{F6357589}
{F6357591}

Reviewers: sammccall, ilya-biryukov, hokein

Reviewed By: sammccall

Subscribers: MaskRay, jkorous, cfe-commits

Differential Revision: https://reviews.llvm.org/D48163

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@334828 91177308-0d34-0410-b5e6-96231b3b80d8