[clang-tools-extra] Fix overzealous linking of dylib to clangTidy

Fix accidentally making clangTidy library link to dylib.  This causes
libclang.so to also link to dylib which results in duplicate symbols
from shared and static libraries, and effectively to registering
command-line options twice.

Thanks to Sylvestre Ledru for noticing this and tracking it down
to r373786.  Fixes PR#43589.

Differential Revision: https://reviews.llvm.org/D68927

git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@374885 91177308-0d34-0410-b5e6-96231b3b80d8

clang-tidy/CMakeLists.txt

diff --git a/clang-tidy/CMakeLists.txt b/clang-tidy/CMakeLists.txt
index 8e747b3..6dadb27 100644
--- a/clang-tidy/CMakeLists.txt
+++ b/clang-tidy/CMakeLists.txt
@@ -31,7 +31,7 @@
   )
 
 if(CLANG_ENABLE_STATIC_ANALYZER)
-  clang_target_link_libraries(clangTidy PRIVATE
+  target_link_libraries(clangTidy PRIVATE
     clangStaticAnalyzerCore
     clangStaticAnalyzerFrontend
   )